Closed fiskus closed 1 month ago
Attention: Patch coverage is 46.03175%
with 136 lines
in your changes missing coverage. Please review.
Project coverage is 37.33%. Comparing base (
3e55c58
) to head (705bf28
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Squashed commits
i don't think it's a good idea tbh, because it makes incremental review hard. commits are automatically squashed when the PR is merged anyways.
commits are automatically squashed when the PR is merged anyways.
I didn't know. Last time I checked, they didn't
commits are automatically squashed when the PR is merged anyways.
I didn't know. Last time I checked, they didn't
check out the network graph under the "insights" tab
I mean: yes, commits are squashed, but messages were just concatenated earlier. I didn't notice when it was changed
I mean: yes, commits are squashed, but messages were just concatenated earlier. I didn't notice when it was changed
oh i see what you mean. we tweaked that setting some time ago, yep
FilesState
toPackageDialog/FilesState.ts
, so I can easily write testsgetNormalizedPath
because it was used only forFilesState
Add empty folder:
FilesState.AddFolder
Drag'n'Drop:
FilesState.Move({ source: string, dest: string })
for added and existing files and directories (so, 4 types ofsource
,dest
is always an added directory)draggable
handler for file/dir icons onlyDndProveder
for managing state: what file do we drag, above what directory, and handle drop.simplescreenrecorder-2024-06-17_16.23.48.webm