Closed dimaryaz closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 38.43%. Comparing base (
273189e
) to head (dfd5fe4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
it was succeeding sometimes
Huh, that seems impossible... Unless CI uses some machines that still use an older release of Python?
it was succeeding sometimes
Huh, that seems impossible... Unless CI uses some machines that still use an older release of Python?
yeah i guess it's related to some kind of caching idk
On Windows,
pathname2url
returns three leading slashes for some reason.urlunparse
has been ignoring them - until Python 3.12, where they result in a URL likefile://///C:/...
.We can instead use
pathlib.PurePath.as_uri
for this. It is certainly cleaner than usingpathname2url
(whose documentation basically says "don't use it") - however, we are still stuck with using theurl2pathname
for the opposite conversion, since there's nopathlib
solution for that.