quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.32k stars 92 forks source link

Remove polyfill.io #4038

Closed nl0 closed 2 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.43%. Comparing base (c01dfd2) to head (ad4fb67).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4038 +/- ## ======================================== Coverage 38.43% 38.43% ======================================== Files 718 718 Lines 33051 33051 Branches 4670 4842 +172 ======================================== Hits 12704 12704 + Misses 19723 19196 -527 - Partials 624 1151 +527 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/4038/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/4038/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `90.75% <ø> (ø)` | | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/4038/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `11.50% <ø> (ø)` | | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/4038/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `87.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fiskus commented 3 weeks ago

Polyfill was added when we replaced Babel with Typescript, as I understand https://github.com/quiltdata/quilt/pull/2043

fiskus commented 3 weeks ago

I checked that ResizeObserver and RelativeTimeFormat, which explicitly polyfiled, work fine in Firefox without polyfill.io

nl0 commented 2 weeks ago

I checked that ResizeObserver and RelativeTimeFormat, which explicitly polyfiled, work fine in Firefox without polyfill.io

yeah, they are widely supported nowadays according to caniuse