Closed drernie closed 3 days ago
Attention: Patch coverage is 66.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 39.25%. Comparing base (
ccdcab9
) to head (afa9725
). Report is 1 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
.../app/containers/Bucket/PackageTree/PackageTree.tsx | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
@fiskus Can you help me out with the "informational" test coverage failure? I don't see any good examples of how to test React.
We tend to ignore these failures.
I can write the test for app/containers/Bucket/CodeSamples/Package.tsx
, but I'm afraid that writing tests for app/containers/Bucket/PackageTree/PackageTree.tsx
would be too difficult.
I've spent 1.5 hours trying to write the test for PackageTree.tsx
, and I think I need at least 2x more time to finish it. So, I'm giving up for now
Description
This is my formal request to allow specifying the Catalog as part of the Quilt+ URI. This will allow applications that take a Quilt+ URI (nf-quilt, QuiltSync) to generate and share human-readable URLs.
Adding it as a fragment appears backwards-compatible; adding it as a query string, on the other hand, breaks the resolver.