quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.33k stars 90 forks source link

Add 'catalog' to Quilt+ URIs #4213

Closed drernie closed 3 days ago

drernie commented 1 week ago

Description

This is my formal request to allow specifying the Catalog as part of the Quilt+ URI. This will allow applications that take a Quilt+ URI (nf-quilt, QuiltSync) to generate and share human-readable URLs.

Adding it as a fragment appears backwards-compatible; adding it as a query string, on the other hand, breaks the resolver.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.25%. Comparing base (ccdcab9) to head (afa9725). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4213 +/- ## ========================================== + Coverage 39.16% 39.25% +0.08% ========================================== Files 775 775 Lines 35086 35088 +2 Branches 5294 5094 -200 ========================================== + Hits 13743 13774 +31 - Misses 20146 20748 +602 + Partials 1197 566 -631 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/4213/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/4213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `91.10% <ø> (ø)` | | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/4213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `14.70% <66.66%> (+0.12%)` | :arrow_up: | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/4213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `92.02% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

drernie commented 3 days ago

@fiskus Can you help me out with the "informational" test coverage failure? I don't see any good examples of how to test React.

fiskus commented 3 days ago

We tend to ignore these failures.

I can write the test for app/containers/Bucket/CodeSamples/Package.tsx, but I'm afraid that writing tests for app/containers/Bucket/PackageTree/PackageTree.tsx would be too difficult.

fiskus commented 3 days ago

I've spent 1.5 hours trying to write the test for PackageTree.tsx, and I think I need at least 2x more time to finish it. So, I'm giving up for now