quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.33k stars 90 forks source link

Put object options #4219

Open drernie opened 1 week ago

drernie commented 1 week ago

Update push et al to take optional arguments to pass to PutObject.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.15%. Comparing base (7fe641e) to head (9180b9b).

Files with missing lines Patch % Lines
api/python/quilt3/api.py 50.00% 1 Missing :warning:
api/python/quilt3/data_transfer.py 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4219 +/- ## ======================================== Coverage 39.14% 39.15% ======================================== Files 775 775 Lines 35072 35077 +5 Branches 5294 5093 -201 ======================================== + Hits 13729 13733 +4 - Misses 20146 20778 +632 + Partials 1197 566 -631 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/4219/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/4219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `91.08% <93.75%> (-0.01%)` | :arrow_down: | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/4219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `14.57% <ø> (ø)` | | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/4219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `92.02% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

drernie commented 1 week ago

@sir-sigurd What else can I check besides that the args get passed to copy_mock?

drernie commented 1 week ago

NOTE: This is too much for me to digest. Unless someone wants to take it on tomorrow, I'll target it for 12/20.