search

quiltt / quiltt-js

Monorepo for Quiltt JS-related packages
https://quiltt.dev/connector/sdk
MIT License
6 stars 0 forks source link

Remove actioncable imported code #10

Open sirwolfgang opened 1 year ago

sirwolfgang commented 1 year ago

Due to some build issues, we imported the action cable code; The fixes should be unstreamed, so that we can reduce the maintenance risk of this part of the code.

rubendinho commented 11 months ago

@sirwolfgang This may be related to: https://github.com/quiltt/quiltt-public/issues/96

I believe all the Apollo stuff should be moved from @quiltt/core to @quiltt/react. @apollo/client is a React package, and also adds unnecessary dependencies to the non-React core JS package.

sirwolfgang commented 11 months ago

@apollo/client is not a react client, it has things to support a react client. https://github.com/apollographql/apollo-client/blob/main/package.json#L66-L86

Anything that an express/node server could also make use of should be in core; but notably a express/node package would also inherent from core.