search

quince-science / QuinCe

QuinCe is an online tool for processing and quality control of data from scientific instruments, with a primary focus on oceanic data.
https://quince.science
GNU General Public License v3.0
7 stars 8 forks source link

equals() abuse #1258

Open squaregoldfish opened 5 years ago

squaregoldfish commented 5 years ago

The equals method is somewhat abused in various parts of the codebase. This should be rectified.

Wherever an equals method is used, make sure it is used sensibly* and that the corresponding hashCode method is present.

Example: equals method just compares one of the fields, and we call equals with that field instead of the object.

squaregoldfish commented 4 years ago

NewInstrumentBean.removeFile