search

quince-science / QuinCe

QuinCe is an online tool for processing and quality control of data from scientific instruments, with a primary focus on oceanic data.
https://quince.science
GNU General Public License v3.0
7 stars 8 forks source link

2995 "Empty QC comment not allowed" error #2998

Closed squaregoldfish closed 2 weeks ago

squaregoldfish commented 2 weeks ago

Fix #2995

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 19.26606% with 88 lines in your changes missing coverage. Please review.

Project coverage is 29.17%. Comparing base (53ac148) to head (7866cfd). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...xeter/QuinCe/web/datasets/plotPage/MapRecords.java 0.00% 21 Missing :warning:
.../uk/ac/exeter/QuinCe/data/Dataset/SensorValue.java 50.00% 5 Missing and 1 partial :warning:
...web/datasets/plotPage/MapRecordJsonSerializer.java 0.00% 6 Missing :warning:
...k/ac/exeter/QuinCe/web/datasets/plotPage/Plot.java 0.00% 6 Missing :warning:
...aset/QC/SensorValues/PositionQCCascadeRoutine.java 0.00% 5 Missing :warning:
...e/web/datasets/plotPage/ManualQC/ManualQCData.java 0.00% 5 Missing :warning:
...sets/export/NeutraliseSalinityFlagsExportData.java 0.00% 4 Missing :warning:
...k/ac/exeter/QuinCe/data/Dataset/DataSetDataDB.java 25.00% 2 Missing and 1 partial :warning:
.../uk/ac/exeter/QuinCe/data/Dataset/Measurement.java 0.00% 3 Missing :warning:
.../exeter/QuinCe/web/datasets/export/ExportBean.java 0.00% 3 Missing :warning:
... and 16 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2998 +/- ## ============================================ + Coverage 29.13% 29.17% +0.03% - Complexity 1972 1981 +9 ============================================ Files 388 388 Lines 19904 19936 +32 Branches 2672 2681 +9 ============================================ + Hits 5799 5816 +17 - Misses 13690 13701 +11 - Partials 415 419 +4 ``` | [Flag](https://app.codecov.io/gh/quince-science/QuinCe/pull/2998/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quince-science) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/quince-science/QuinCe/pull/2998/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quince-science) | `29.17% <19.26%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quince-science#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.