search

quininer / tokio-rustls

Asynchronous TLS/SSL streams for Tokio using Rustls.
142 stars 38 forks source link

List `tokio-proto` feature #17

Closed sanmai-NL closed 6 years ago

sanmai-NL commented 6 years ago

Without it, cargo-outdated shows the feature is outdated i.e. doesn’t exist. With it, I hope not. It surely doesn’t hurt to make the feature explicit.

quininer commented 6 years ago

Should this be a cargo-outdated bug?

sanmai-NL commented 6 years ago

I don't think so. Features should be made explicit in Cargo.toml, don't you think? The feature was misnamed unfortunately: the name isn't valid given the existence of a dependency with the same name (see CI logs). The best fix would be to rename the feature.

quininer commented 6 years ago

I agree with the use of an explicit feature, but this will be a break change.

I will merge in the next version.

sanmai-NL commented 6 years ago

@quininer: I've found new information which makes me close this PR, it's harmful. It has turned out that it's indeed a cargo-outdated bug: kbknapp/cargo-outdated#100. The Rust API guidelines appear to promote implicit features for optional dependencies C-FEATURE.