search

quininer / tokio-rustls

Asynchronous TLS/SSL streams for Tokio using Rustls.
142 stars 38 forks source link

Consider renaming to futures-rustls #31

Closed cramertj closed 5 years ago

cramertj commented 5 years ago

This crate doesn't have any dependency on the tokio runtime today-- it'll work on any futures-compatible executor. At the moment it's rather hard to sort out which libraries are executor-agnostic and which are not. Would you consider renaming to help clarify this?

quininer commented 5 years ago

I have this idea! but I want there are some examples that run on other executors.

cramertj commented 5 years ago

Today tokio is the primary cross-platform executor. tokio-rustls also works with the Fuchsia executor, but I don't think it'd be appropriate to add an example for that since it's not something most people would be able to run, and it wouldn't be possible to check it in CI.

quininer commented 5 years ago

I have publish a futures-rustls crate as a placeholder on crates.io and I hope I can rename it in next version.

quininer commented 5 years ago

I changed the plan a little.

Originally I wanted to make tokio-rustls compatible with tokio-io and futures-io, but this is a bit complicated and redundant.

Now I decided to release futures-rustls for futures-io and continue to maintain tokio-rustls until tokio is fully migrated to futures 0.3.

quininer commented 5 years ago

futures-rustls is already available.

cramertj commented 5 years ago

Awesome, thank you! :)