search

quininer / tokio-rustls

Asynchronous TLS/SSL streams for Tokio using Rustls.
142 stars 38 forks source link

Switch to Tokio 0.2 #41

Closed briansmith closed 4 years ago

briansmith commented 5 years ago

See the Twitter thread https://twitter.com/seanmonstar/status/1148732643120275456. It would be great for tokio-rustls to use std::future so that the new std::future-based hyper can make use of it. I'm not sure what's all required to make that happen.

quininer commented 5 years ago

tokio-rustls already has a branch that supports std::future, but tokio 0.2 doesn't seem to be using futures-io.

I will try to port it to tokio 0.2 this weekend. https://github.com/quininer/tokio-rustls/issues/40

briansmith commented 5 years ago

@seanmonstar Do you have any suggestions for dealing with Tokio + std::future right now? I imagine you must have already solved it to get Hyper working with std::future.

seanmonstar commented 5 years ago

So far in hyper, I've just been using tokio_io::{AsyncRead, AsyncWrite}.

DoumanAsh commented 5 years ago

afaik I remember Carl mentioning that he is not sure what to do with AsyncRead and AsyncWrite so for now they left it in tokio-io so it can go either like that or eventually it will alias futures's traits

quininer commented 5 years ago

I have built a tokio 0.2 branch.

CryZe commented 5 years ago

I ported hyper-rustls to use this branch and everything seems to be working :D

DoumanAsh commented 5 years ago

@quininer btw Carl removed tokio-futures and now they just re-export from futures crate

quininer commented 4 years ago

tokio-rustls 0.12.0 has been released.