Race condition in vban_receptor (jack back-end)

quiniouben / vban

VBAN protocol open-source implementation

GNU General Public License v3.0

450 stars 63 forks source link

Race condition in vban_receptor (jack back-end) #38

Open HFS40000 opened 4 years ago

HFS40000 commented 4 years ago

With the jack audio back-end, the callback thread is started before ports are registered. jack_port_get_buffer tries to open a NULL port and we segfault. (in jack_process_cb). I moved jack_activate to the end of jack_start and it works.

quiniouben commented 4 years ago

Hi, thank you for improving this. The jack backend is very rarely used it seems and was implemented a bit quick-and-dirty. Can you create a pull request from you changes ? I would quickly review and integrate.