quinlan-lab / pathoscore

pathoscore evaluates variant pathogenicity tools and scores.
MIT License
21 stars 8 forks source link

ftp for clinvar true set has changed #31

Closed edgarjavi closed 7 years ago

edgarjavi commented 7 years ago

There is a new version of the vcf in clinvar, the file with the 20170802 data is archived. Here is the new line of code from the make.sh file with the new location

wget ftp://ftp.ncbi.nih.gov/pub/clinvar/vcf_GRCh37/vcf2.0/archive/2017/clinvar${date}.vcf.gz

jimhavrilla commented 7 years ago

That's already in the make.sh

Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

On Mon, Sep 11, 2017 at 3:13 PM, Javier notifications@github.com wrote:

There is a new version of the vcf in clinvar, the file with the 20170802 data is archived. Here is the new line of code from the make.sh file with the new location

wget ftp://ftp.ncbi.nih.gov/pub/clinvar/vcf_GRCh37/vcf2.0/ archive/2017/clinvar${date}.vcf.gz

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BCM2BDmAiR2TqxsyMQIGqBZFHoqfks5shaKDgaJpZM4PTx3p .

jimhavrilla commented 7 years ago

You mean the september one is new? ftp://ftp.ncbi.nih.gov/pub/clinvar/vcf_GRCh37/vcf_2.0/clinvar_20170905.vcf.gz ?

Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

On Mon, Sep 11, 2017 at 3:15 PM, Jim Havrilla semjaavria@gmail.com wrote:

That's already in the make.sh

Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

On Mon, Sep 11, 2017 at 3:13 PM, Javier notifications@github.com wrote:

There is a new version of the vcf in clinvar, the file with the 20170802 data is archived. Here is the new line of code from the make.sh file with the new location

wget ftp://ftp.ncbi.nih.gov/pub/clinvar/vcf_GRCh37/vcf2.0/archiv e/2017/clinvar${date}.vcf.gz

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BCM2BDmAiR2TqxsyMQIGqBZFHoqfks5shaKDgaJpZM4PTx3p .

edgarjavi commented 7 years ago

yeah the clinvar make.sh wont run because the ftp location is outdated

jimhavrilla commented 7 years ago

I will update the date then.

Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

On Mon, Sep 11, 2017 at 3:20 PM, Javier notifications@github.com wrote:

yeah the clinvar make.sh wont run because the ftp location is outdated

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/issues/31#issuecomment-328661939, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BKxhl_fAMWRYWn1gSTjVwezLYONTks5shaQGgaJpZM4PTx3p .

jimhavrilla commented 7 years ago

Or do you recommend we move to the archive location?

Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

On Mon, Sep 11, 2017 at 3:21 PM, Jim Havrilla semjaavria@gmail.com wrote:

I will update the date then.

Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

On Mon, Sep 11, 2017 at 3:20 PM, Javier notifications@github.com wrote:

yeah the clinvar make.sh wont run because the ftp location is outdated

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/issues/31#issuecomment-328661939, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BKxhl_fAMWRYWn1gSTjVwezLYONTks5shaQGgaJpZM4PTx3p .

edgarjavi commented 7 years ago

Exactly, the line I sent above gets the file with the old date.

jimhavrilla commented 7 years ago

Actually I think I have a fix. I can try to pull if the newest one is there and exists, otherwise, check the archive for the date. This will probably need to be changed in 2018 as well, since the archives will shift there. Probably a constantly mutable make.sh to stay up-to-date. Thanks for making me aware of it. I'll push a fix.

brentp commented 7 years ago

let's keep it so it points to the latest file in the archive directory.

jimhavrilla commented 7 years ago

done.