search

quinlan-lab / pathoscore

pathoscore evaluates variant pathogenicity tools and scores.
MIT License
21 stars 8 forks source link

code and documentation for AD gene set #8

Closed jimhavrilla closed 7 years ago

jimhavrilla commented 7 years ago

removed exome flattening script, replaced with bedtools merge, added README.md

fix to make.sh that merges after gene match

brentp commented 7 years ago

can you update your master branch and then make this PR so I can see the diff?

brentp commented 7 years ago

it's easier to to dev this way (for you) if you create a branch and push to that branch instead of using master.

jimhavrilla commented 7 years ago

Ok so pull and switch branches

On Sat, Jul 15, 2017 at 5:51 PM Brent Pedersen - Bioinformatics < notifications@github.com> wrote:

it's easier to to dev this way (for you) if you create a branch and push to that branch instead of using master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/pull/8#issuecomment-315571114, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BEIJvGF7SNV1S_eZdRe8TrFPaErUks5sOVB5gaJpZM4OYy8J .

-- Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

jimhavrilla commented 7 years ago

Think I did it right?

On Sat, Jul 15, 2017 at 5:52 PM Jim Havrilla semjaavria@gmail.com wrote:

Ok so pull and switch branches

On Sat, Jul 15, 2017 at 5:51 PM Brent Pedersen - Bioinformatics < notifications@github.com> wrote:

it's easier to to dev this way (for you) if you create a branch and push to that branch instead of using master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/pull/8#issuecomment-315571114, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BEIJvGF7SNV1S_eZdRe8TrFPaErUks5sOVB5gaJpZM4OYy8J .

-- Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

-- Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

brentp commented 7 years ago

you'll probably have to make a different branch, pull from master, merge your master, then push, then make a new PR.

jimhavrilla commented 7 years ago

Ok I added your original repo as a remote upstream then pulled and pushed to my master branch with no issues. Is this ok?

On Sat, Jul 15, 2017 at 6:31 PM Brent Pedersen - Bioinformatics < notifications@github.com> wrote:

you'll probably have to make a different branch, pull from master, merge your master, then push, then make a new PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/pull/8#issuecomment-315572769, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BGNZlemqV0tuSHjFumkR1PDY9vgYks5sOVnYgaJpZM4OYy8J .

-- Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

brentp commented 7 years ago

no. you'll have to do what I suggested.

jimhavrilla commented 7 years ago

Didn't realize i had to do it on the site. I think I did what you suggested now

On Sat, Jul 15, 2017 at 6:47 PM Brent Pedersen - Bioinformatics < notifications@github.com> wrote:

no. you'll have to do what I suggested.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/pull/8#issuecomment-315573306, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BO1LpRknfJHbbTbWq3t1_OoqjYH4ks5sOV2_gaJpZM4OYy8J .

-- Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

brentp commented 7 years ago

you'll have to close this PR and make the PR from another branch.

jimhavrilla commented 7 years ago

My non-master branch?

On Sat, Jul 15, 2017 at 7:21 PM Brent Pedersen - Bioinformatics < notifications@github.com> wrote:

you'll have to close this PR and make the PR from another branch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quinlan-lab/pathoscore/pull/8#issuecomment-315574642, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ8BB45g7XfLtXX4qd-5Q1DK3pR0gzcks5sOWWhgaJpZM4OYy8J .

-- Jim Havrilla PhD Candidate in Human Genetics, University of Utah Accelerated BS/MS in Biomedical Engineering, Drexel University '12, Concentration: Bioinformatics "Memory, comprehension, communication, motivation"

brentp commented 7 years ago

yes