quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.85k stars 394 forks source link

async-std support, second try #1345

Closed yu-re-ka closed 2 years ago

yu-re-ka commented 2 years ago

Unlike the first try, this does not rely on mutually exclusive feature flags. Both runtime-async-std and runtime-tokio features can be enabled at the same time. The actual runtime used is chosen by the user when creating the endpoint.

This does not touch the synchronization primitives (still uses channels etc. from tokio, even when running under async-std), and thus keeps tokio as hard-coded dependency.

To-Do:

yu-re-ka commented 2 years ago

@Ralith do you think this is an acceptable solution?

yu-re-ka commented 2 years ago

CI passes 🎉

yu-re-ka commented 2 years ago

@Ralith please have a look at the current state of #1346 and tell me if it addresses all issues you raised