Closed Ralith closed 2 years ago
Sorry for the slow review...
No worries; it's not particularly pressing, nor a rebase hazard.
Still TODO: Actually getting rid of NewConnection
, unless there's a compelling reason to keep it around.
That seems to have panned out to a pleasant simplification in the tests/examples. Less unwrap
, less nesting, and fewer intermediate variables all 'round.
Experimenting with a return to named 'static futures, motivated by downstream use cases. See e.g. https://github.com/hyperium/h3/pull/80.
Open questions:
Also included is an idea to drop
NewConnection
in favor of unobtrusive async methods onConnection
, bundled because they would have to be rewritten to match this PR's approach if it move forwards. I'd like feedback on this change before I invest the effort to actually removeNewConnection
and update all the examples/docs.