quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.85k stars 394 forks source link

Port fix for address layout reliance to 0.8 #1392

Closed djc closed 2 years ago

djc commented 2 years ago

I guess we should yank 0.1.{0,1,2}?

cc @est31 I'm not quite motivated to backport this to older versions than 0.8, but you might be interested.

Ralith commented 2 years ago

I guess we should yank 0.1.{0,1,2}?

Makes sense.

djc commented 2 years ago

Published 0.1.3 and yanked all previous versions.

djc commented 2 years ago

On second thought, I unyanked 0.1.2 so folks can take a little longer to upgrade, I guess? I'll yank it tomorrow.

Ralith commented 2 years ago

Doesn't yanking only affect new checkouts? It shouldn't be too disruptive unless people are pinning patch versions, which is unusual.

est31 commented 2 years ago

Yanking affects people who have the version in their Cargo.lock too, because Cargo prints a warning in that instance. But admittedly this is only a light warning. I don't think that waiting is needed.

djc commented 2 years ago

Okay, yanked it again.