search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.85k stars 394 forks source link

Upgrade tokio to resolve ntapi & tokio-rs/mio dependency warning #1437

Closed temportalflux closed 2 years ago

temportalflux commented 2 years ago

Tokio 1.13 uses ntapi 0.3.6 as a dependency, which will be rejected by a future version of Rust. This causes compiler warnings for users of quinn. Upgrading to tokio >1.17 (preferably latest of 1.21) may resolve this warning (https://github.com/tokio-rs/tokio/releases/tag/tokio-1.17.0). "warning: the following packages contain code that will be rejected by a future version of Rust: ntapi v0.3.6"

Only found this dependency in the quinn tree by using cargo tree, and searching for ntapi.

djc commented 2 years ago

You can just cargo update your workspace and everything will be fine, right?

temportalflux commented 2 years ago

I.... did not know I could do that... and that fixed it too 😅