quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.85k stars 394 forks source link

quinn-proto v0.10.0 w/ rustls v0.21.0 #1515

Closed cpu closed 1 year ago

cpu commented 1 year ago

Description

Update branch for quinn-proto v0.10.0, using Rustls v0.21.0

deps: upgrade rustls v0.20.3 -> v0.21.0.

This commit updates Quinn's dependency on Rustls from v0.20.3 to v0.21.0.

This release includes a handful of small breaking changes which are resolved alongside the upgrade.

quinn-proto: bump version 0.9.2 -> 0.10.0.

As part of upgrading the quinn-proto rustls dependency we must do a semver incompatible version bump since rustls is exposed as part of the public API.

Blocking tasks

cpu commented 1 year ago

Would be nice to squash most of these changes (except the one that seems like a technically unrelated bugfix), and also treat this branch/PR as the eventual upgrade PR (removing some of the test language from the PR title/description).

:ballot_box_with_check: - Done.

Also would be nice to include a separate commit that bumps the version number for quinn-proto to 0.10.0

:ballot_box_with_check: - Done w/ 0ad878c

cpu commented 1 year ago

cpu force-pushed the cpu-smoke-test-rustls-quic-conns branch from 0ad878c to e17beaa

I wanted to refresh this branch now that https://github.com/rustls/rustls/pull/1216 was merged. I'm glad I did because it shook out a couple errors, now addressed in https://github.com/rustls/rustls/pull/1236 I've switched the Patch to that branch for the short term.

cpu commented 1 year ago

cpu force-pushed the cpu-smoke-test-rustls-quic-conns branch from e17beaa to 429380a

Fixed one more breaking change from upstream:

error[E0432]: unresolved import `rustls::internal::msgs::enums::AlertDescription`
  --> quinn-proto/src/tests/mod.rs:13:5
   |
13 | use rustls::internal::msgs::enums::AlertDescription;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `AlertDescription` in `msgs::enums`
cpu commented 1 year ago

cpu force-pushed the cpu-smoke-test-rustls-quic-conns branch from 429380a to d79ed33

Now back to tracking rustls/main in the Patch since https://github.com/rustls/rustls/pull/1236 was merged.

cpu commented 1 year ago

@djc @Ralith This branch should be ready to go now that Rustls 0.21.0 is available :tada: