quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.85k stars 394 forks source link

Allow compilation with `--cfg fuzzing` but not `--features=arbitrary` #1574

Closed smoelius closed 1 year ago

smoelius commented 1 year ago

Right now, if quinn-proto is built without --features=arbitrary, one gets an error about an unresolved import. The compile_error helps to clarify why.

An alternative would be to try and disentangle --cfg fuzzing and --features=arbitrary. But this change is less invasive.

djc commented 1 year ago

An alternative would be to try and disentangle --cfg fuzzing and --features=arbitrary. But this change is less invasive.

Did you try looking at this? I think I would usually prefer disentangling over this.

smoelius commented 1 year ago

Did you try looking at this? I think I would usually prefer disentangling over this.

I did not, but if you hold off on merging, I will.

smoelius commented 1 year ago

@djc Is this better?

djc commented 1 year ago

Yes, thank you!