search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.85k stars 394 forks source link

Bump quinn-proto version to 0.9.6 #1675

Closed grooviegermanikus closed 1 year ago

grooviegermanikus commented 1 year ago

includes:

djc commented 1 year ago

What's the point here? The minimum bound for quinn-proto already allows 0.9.4 which is semver-compatible with 0.9.5.

grooviegermanikus commented 1 year ago

you mean that I should rather point to Quinn 0.9.4 and quinn-proto 0.9.5?

I expected that Quinn 0.9 5 without proto should do it.

or am I missing sth?

regards!

grooviegermanikus commented 1 year ago

tried this: cargo update -p quinn-proto

gives:

Updating quinn-proto v0.9.4 -> v0.9.5

yet this does not compile: transport_config.enable_segmentation_offload(false)

djc commented 1 year ago

Yes, you need to bump the quinn-proto version to 0.9.6 because we made another 0.9.5 release without this since my previous suggestion. No need to bump the quinn version though.

grooviegermanikus commented 1 year ago

oops failed to rename the branch

djc commented 1 year ago

It looks like the FreeBSD failure was a fluke, and the clippy job has been failing on 0.9.x for a while.

djc commented 1 year ago

Published 0.9.6.