quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

Remove "max_tlps" configuration variable #1713

Closed link2xt closed 10 months ago

link2xt commented 10 months ago

It is not used since https://github.com/quinn-rs/quinn/pull/134 (commit bdc9ac76a453208848a58bf3b24a633ade8b299a) was merged in 2018.

RFC 9002 also does not mention Tail Loss Probe except that it has been integrated into the PTO (Probe Timeout) mechanism.

link2xt commented 10 months ago

This is technically an API-breaking change, but anyone trying to set this variable should just stop doing it as it is a no-op. This is IMO better than a misleading variable that someone might try to tweak and evaluate the results only to measure some noise.