search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

ClientConfig transport and ServerConfig transport have different visibility #1714

Open BlinkyStitt opened 10 months ago

BlinkyStitt commented 10 months ago

ClientConfig's transport has pub(crate), while ServerConfig's transport has pub. Is this difference intentional? I think both should be pub so that updating the client's transport is easier (unless I'm not supposed to be doing that? I'm new to this).

Ralith commented 10 months ago

The intention is that you should generally use the setter methods. Does that work for your case? Perhaps we should privatize the ServerConfig fields for consistency.

BlinkyStitt commented 8 months ago

Consistency was my main reason for opening the issue.

I don't remember exactly what was missing now, but I think the setters that exist were missing something.

Ralith commented 5 months ago

Every time I try to clean this up it turns out to be more complicated than I expected, but we should definitely try to be consistent one way or another here.