quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

udp: use io::Result<> where possible #1736

Closed stormshield-damiend closed 8 months ago

stormshield-damiend commented 8 months ago

Use io::Result<> in quinn-udp module. This was found as non blocking in #1701

Ralith commented 8 months ago

Thanks!

I would prefer doing it the other way around

Oh, is that how we ended up with these? I feel like Result aliases are at least a well established convention, and in particular io::Result is very widely used.

djc commented 8 months ago

I'm definitely not a fan of unprefixed Result aliases, though I agree the qualified io::Result is common enough that I don't mind it as much.