search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

Upgrade ring to 0.17.7 #1751

Closed hack3ric closed 8 months ago

hack3ric commented 8 months ago

ring 0.17.7 brings new platform support such as RISC-V and LoongArch, and is in line with rustls' ring version, thus avoiding multiple ring packages of different versions to be built.

djc commented 8 months ago

See #1715.

hack3ric commented 8 months ago

See #1715.

Sorry about not digging deeper. I didn't find introducing solely ring upgrade causing any incompatibilities while working on building on RISC-V. I guess it could be better to merge the ring upgrade part and release the non-breaking changes first?

zh-jq-b commented 8 months ago

Since rustls 0.21.10 switched to ring 0.17, this does seem like an easy win. Am I forgetting something?

https://github.com/quinn-rs/quinn/issues/1678

Ralith commented 8 months ago

Ah, right, it's a breaking change, so we can't release it alone without excessive churn, and it's a trivial enough change that there's not really any benefit from merging it early otherwise. Still, thanks for bringing it up!