Open gretchenfrage opened 7 months ago
I'm creating this issue as a list of miscellaneous things that we're noticing should be cleaned up in the course of developing #1752 but which would not be in scope for that issue itself:
quinn::Connecting
#[must_use]
quinn::Connecting::local_ip
poll
Ready
remote_address
quinn::Connecting::remote_address
quinn_proto::TransportError
quinn_proto::ConnectionError
I'm creating this issue as a list of miscellaneous things that we're noticing should be cleaned up in the course of developing #1752 but which would not be in scope for that issue itself:
quinn::Connectinghas a#[must_use]annotation denoting that it is a future which is obsolete as Rust now does that automaticallyquinn::Connecting::local_ipis missing a comment stating that it will panic if called afterpollhas returnedReadylike itsremote_addressmethod hasquinn::Connecting::remote_addresshas a trailing punctuation on the first line of its doc comment, which is inconsistent with general project stylequinn_proto::TransportErrorand other downstream-API-exposed types despite that being a public part of quinn's API via quinn's re-exporting ofquinn_proto::ConnectionError