Fix constant of frame_type IMMEDIATE_ACK

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.57k stars 364 forks source link

Fix constant of frame_type IMMEDIATE_ACK #1774

Closed nemethf closed 3 months ago

nemethf commented 3 months ago

Both the draft and the IANA registry say the current value for frame_type IMMEDIATE_ACK is 0x1F.

https://www.iana.org/assignments/quic/quic.xhtml https://datatracker.ietf.org/doc/html/draft-ietf-quic-ack-frequency#section-10.2

nemethf commented 3 months ago

Do you want/need a maintenance release for this?

It is not necessary. We're not interested in interoperability just yet. Thank you.

djc commented 3 months ago

Who is we? What's your interest/use case?

levaitamas commented 3 months ago

Who is we? What's your interest/use case?

I guess @nemethf was referring to me. :smile: We are experimenting with real-time media traffic, and it turns out that both gstreamer quicsink/quicsrc and moq-rs uses quinn.