Enable `ios` for the same os_type checks as `macos`

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.57k stars 364 forks source link

Enable `ios` for the same os_type checks as `macos` #1788

Closed jamilbk closed 3 months ago

jamilbk commented 3 months ago

It appears that IPv4-only is broken on iOS.

Enabling the same code paths for ios that exist for macos fixes all issues. In our testing, we've found the network stacks to be nearly identical between iOS and macOS.

This fork has been tested on 3 physical iOS devices with IPv4-only, IPv6-only, and dual stack configurations on iOS 17.

Thanks for the great library. Happy to do any further testing!

djc commented 3 months ago

Thanks! Looks like this causes some issues in CI?

jamilbk commented 3 months ago

Hmm, is the CI expected to fail for this? I would not have expected this change to affect macos tests. I'll take a closer look.

jamilbk commented 3 months ago

https://github.com/quinn-rs/quinn/pull/1788/commits/248ac33ff79ba3173e794aa63cc814d70f4714b3 fixes the issue. Sorry about that! Glad CI caught it. Please give it a once-over.

Thanks for accepting!