quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.57k stars 363 forks source link

Add riscv64 Support #1812

Closed liberodark closed 2 months ago

liberodark commented 2 months ago

Hi,

Have build issue related to ring from : https://gitlab.com/veloren/veloren/-/issues/1972 More info : https://paste.yunohost.org/opecoqopep.vbs Also i can give you access on risc-v if you need.

How to build :

#!/bin/bash

apt install -y git curl
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
git clone https://github.com/quinn-rs/quinn
cd quinn
source "$HOME/.cargo/env"
cargo build --release

Fail with ring 0.16.7 Work with ring 0.17.8

Best Regards

djc commented 2 months ago

Can you try with #1715?

liberodark commented 2 months ago

Hi, @djc no have make PR to fix that with minor change.

Best Regards

liberodark commented 2 months ago

Hi, @djc I saw your PR but it is not merged. So I wanted to make a precise fix with as little change as possible. Unlike your PR. I didn't understand that you were a lead developer. So this issue can be corrected very simply. You just need to update ring to 0.17.8

Best Regards

djc commented 2 months ago

@liberodark ring is a public dependency for us so upgrading it is not a trivial matter of just bumping the version. You'll have to wait for the PR to be merged (which is now ready for review -- it shouldn't be too long) just like everyone else.

liberodark commented 2 months ago

No problem im go to wait for that thank for your reply.