quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.57k stars 363 forks source link

Clarify Connection::space_can_send logic #1851

Closed Ralith closed 1 month ago

Ralith commented 1 month ago

Testing and re-examination reveals that this doesn't actually change any behavior, because if ACKs were sendable then SendableFrames::acks would have been set by the first PacketSpace::can_send call. We only reach the case that hard-codes that to false if we already know it would have returned false. Cleaned up the logic a bunch to avoid future confusion; please review carefully for absence of semantic changes.

djc commented 1 month ago

Much easier to review, thanks!