Reduce black hole detection false positives

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.52k stars 356 forks source link

Reduce black hole detection false positives #1858

Closed Ralith closed 2 weeks ago

Ralith commented 3 weeks ago

Fixes #1855.

TODO:

[x] Document/justify the new design
[x] Handle out-of-order acknowledgements
[x] Test new behavior

Ralith commented 3 weeks ago

Redesigned per chat to be robust against two-pass ACK procssing, and a bit simpler than the original plan besides. Still need to add tests and some high-level overview docs, but I think I'm happy with the shape of the code.

Ralith commented 2 weeks ago

Addressed feedback and revised documentation. Test coverage of the new capabilities still TODO.

Ralith commented 2 weeks ago

Added some tests; feel free to suggest any interesting cases I may have missed.

djc commented 2 weeks ago

(Maybe add a quinn-proto version bump here? Between #1857, #1859 and this it feels like a release might be good.)

Ralith commented 2 weeks ago

Sorry, I think I'm close to reaching the end of this iterative feedback stream...

No worries, this isn't urgent and I'm as happy as ever to get good feedback!