quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.57k stars 364 forks source link

Simpler and more precise ID flow control update check in Chunks #1874

Closed Ralith closed 1 month ago

Ralith commented 1 month ago

Noticed this looked like a redundant approximation while working on #1873. Careful review desired. The original logic here seems to date back to 2021 or earlier, but e.g. a3b35f93c25045b00849e846713cb9b94bc681c5 looks like a somewhat shorter-sighted hack around this same quirk. See commit description for additional rationale.

djc commented 1 month ago

Nice!