quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.57k stars 364 forks source link

fix: remove unused dependency tracing-attributes #1903

Closed mxinden closed 1 week ago

mxinden commented 1 week ago

Various quinn* crates depend on tracing. tracing in its default feature set includes tracing-attributes in order to expose #[instrument] procedural macro in tracing::instrument.

None of quinn* make use of the #[instrument] macro. Thus the tracing-attributes dependency is unused.

To remove the dependency from the tree, this commit:

  1. Restricts tracing's features to std, effectively removing the attributes feature.
  2. Consolidates the various tracing* imports across quinn* crates into workspace dependencies.

Let me know if you don't want to use workspace dependencies?


Context:

As always, thank you for this project!

djc commented 1 week ago

Very cool to see that quinn-udp is being considered for use in Firefox!