Closed magsol closed 8 years ago
In function docstrings, the primitives types (integer, float, string, etc) are all being specified correctly. However, with the vector / matrix structures, we need to go a step further.
Rather than simply specify vct_input : vector
, we need to provide the user with the type array
(since that can imply vector or matrix), as well as the shape
of the array. For example, a vector with length T
would look like this:
vct_input : array, shape (T)
Similarly, a matrix with P rows and T columns would be documented like this:
mat_input : array, shape (P, T)
All parameters and return values that are arrays should have this form.
Thanks for such a good point, I'll apply it right now.
There are many small syntactical fixes that need to be made for the code to be production-ready and open sourced. They include (but are not limited to):
x = 5
, rather thanx=5
)var1, var2
instead ofvar1,var2
)