quinngroup / dr1dl-pyspark

Dictionary Learning in PySpark
Apache License 2.0
1 stars 1 forks source link

Fix imports #27

Closed magsol closed 8 years ago

magsol commented 8 years ago

Import statements in Python files need to follow three guidelines:

For example:

import numpy as np
import numpy.testing
import numpy.linalg as sla
import argparse

is incorrect. The correct ordering would be:

import argparse
import numpy as np
import numpy.linalg as sla
import numpy.testing

For example:

from numpy import linalg as sla

is incorrect. Rather, use this formulation:

import numpy.linalg as sla
MOJTABAFA commented 8 years ago

Thanks for elaborating such technical issues. It's already done.