search

quinngroup / dr1dl-pyspark

Dictionary Learning in PySpark
Apache License 2.0
1 stars 1 forks source link

Remove unused variables #29

Closed magsol closed 8 years ago

magsol commented 8 years ago

There are some variables that are defined but never used. Particular examples include RAND_MAX, file_summary, and totoalResidual.

Also, I believe totoalResidual is misspelled. But even its correctly-spelled version is never used, so the variable should either be used somewhere or deleted entirely.

MOJTABAFA commented 8 years ago

total residual is already used in c++ code for log file. Regarding to pseudo code we don't need the log file here. so it can be eliminated. file_summary is also useless here, since it has been used for logging( in c code )

MOJTABAFA commented 8 years ago

it's done now. Thanks