search

quinngroup / dr1dl-pyspark

Dictionary Learning in PySpark
Apache License 2.0
1 stars 1 forks source link

u_old is not 0-mean #36

Closed magsol closed 8 years ago

magsol commented 8 years ago

On line 106, where u_old is defined as a random T-length vector, the pseudocode indicates the vector should be 0-mean and unit-length, but the mean is never subtracted off. Please add that operation.

MOJTABAFA commented 8 years ago

@magsol yes, if you check the previous version of code you can see before it was there , but I don't know what it has eliminated from the code. anyway, I applied it now and checked the output, now it's more rational but still not generating a full accurate output.

Thanks.