search

quinnj / JSON3.jl

Other
214 stars 47 forks source link

Don't manually inline read on Struct to avoid excessive compilation #206

Closed quinnj closed 2 years ago

quinnj commented 2 years ago

Resolves #205. The @inline annotation here can lead to excessive compilation for deeply nested structures where the top-most Struct read call will recursively inline all nested Struct read calls. The function is so large and type-stable anyway that it's not worth inlining anyway.

codecov[bot] commented 2 years ago

Codecov Report

Merging #206 (757536d) into main (76eb977) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files           9        9           
  Lines        1694     1694           
=======================================
  Hits         1505     1505           
  Misses        189      189
Impacted Files Coverage Δ
src/structs.jl 89.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76eb977...757536d. Read the comment docs.