search

quinnj / JSON3.jl

Other
214 stars 47 forks source link

fix: vector expression generation within union #218

Closed mcmcgrath13 closed 2 years ago

mcmcgrath13 commented 2 years ago

It was assumed that we would only need to generate an expression on a vector when the vector was the root of the JSON's type, but a vector can also appear in a union type. In the root case, we unwrap the eltype and generate an expression based on that, but in the union case this is inappropriate.

This PR distinguishes between the two cases for vectors and keeps the vector wrapper when we are not at the root of the expression.

codecov[bot] commented 2 years ago

Codecov Report

Merging #218 (e2d4042) into main (35a5d67) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   88.87%   88.88%   +0.01%     
==========================================
  Files           9        9              
  Lines        1699     1701       +2     
==========================================
+ Hits         1510     1512       +2     
  Misses        189      189
Impacted Files Coverage Δ
src/gentypes.jl 96.42% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35a5d67...e2d4042. Read the comment docs.