Closed onetonfoot closed 1 year ago
Sorry for the add on, but could you also add a test for this?
Base: 88.36% // Head: 88.37% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
efb0b0c
) compared to base (8569ff9
). Patch coverage: 100.00% of modified lines in pull request are covered.:exclamation: Current head efb0b0c differs from pull request most recent head 2ae5e08. Consider uploading reports for the commit 2ae5e08 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Good thing you asked for some test cases, it wasn't behaving as expected when reading types
Any chance we can get this merged?
@mcmcgrath13 does this look good to you? I think it LGTM
Thanks! Could you also update the type generation uses of JSON.read to no longer do the file checks? Seems like it shouldn't be necessary anymore with this change.