search

quinnj / JSON3.jl

Other
214 stars 47 forks source link

Fix JSON3.write for non-traditional indexed AbstractVector #261

Closed quinnj closed 1 year ago

quinnj commented 1 year ago

The previous code was assuming that length(x) was comparable to each eachindex(x), which isn't always true for weird non-linear arrays.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (b23f72b) 89.69% compared to head (9c3e910) 89.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #261 +/- ## ======================================= Coverage 89.69% 89.69% ======================================= Files 10 10 Lines 1775 1775 ======================================= Hits 1592 1592 Misses 183 183 ``` | [Impacted Files](https://app.codecov.io/gh/quinnj/JSON3.jl/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jacob+Quinn) | Coverage Δ | | |---|---|---| | [src/write.jl](https://app.codecov.io/gh/quinnj/JSON3.jl/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jacob+Quinn#diff-c3JjL3dyaXRlLmps) | `84.68% <83.33%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.