quinnj / JSON3.jl

Other
214 stars 47 forks source link

More robust handling of filenames, paritucalrly errors about too long #264

Open nstiurca opened 1 year ago

nstiurca commented 1 year ago

On my system, I'm actually triggering the ENAMETOOLONG error code with strings of length ~150 characters. Not sure why, but I re-wrote the code based on the suggestion in the upstream bug.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.02 :warning:

Comparison is base (e33786c) 89.69% compared to head (ec5fd2c) 89.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #264 +/- ## ========================================== - Coverage 89.69% 89.67% -0.02% ========================================== Files 10 10 Lines 1775 1782 +7 ========================================== + Hits 1592 1598 +6 - Misses 183 184 +1 ``` | [Impacted Files](https://app.codecov.io/gh/quinnj/JSON3.jl/pull/264?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jacob+Quinn) | Coverage Δ | | |---|---|---| | [src/utils.jl](https://app.codecov.io/gh/quinnj/JSON3.jl/pull/264?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jacob+Quinn#diff-c3JjL3V0aWxzLmps) | `89.20% <85.71%> (-0.27%)` | :arrow_down: | | [src/read.jl](https://app.codecov.io/gh/quinnj/JSON3.jl/pull/264?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jacob+Quinn#diff-c3JjL3JlYWQuamw=) | `88.73% <100.00%> (+0.03%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.