Closed palday closed 10 months ago
@quinnj 1.9 isn't the new LTS yet -- LTS can't be declared until the following release is out. But that said, I think bumping compat to 1.9 for a new feature in an otherwise stable package is a good choice and that's what I've done here. We can revisit this decision is there is a loud outcry from 1.6 users. 😄
@palday I'm concerned about the Beacon-internal impact of requiring 1.9 here actually. Let's confirm before merging this that that's okay.
Instead of dropping support for old Julia versions, why not just gate this particular Arrow functionality behind a @static if Base.VERSION >= v"1.9-"
? So then JSON3 will still be usable on old Julia versions, but the Arrow functionality will only be available on Julia 1.9 and later.
@DilumAluthge The lazy loading of extensions already does that, but I was thinking about adding just such a gate to the tests.
@quinnj gentle bump 🖤
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #274 +/- ## ========================================== + Coverage 89.67% 89.68% +0.01% ========================================== Files 10 11 +1 Lines 1821 1823 +2 ========================================== + Hits 1633 1635 +2 Misses 188 188 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.