Closed junghans closed 6 years ago
Looks good, thanks. Please see minor comment below. Good to go.
Reviewed 2 of 2 files at r1. Review status: all files reviewed, 2 unresolved discussions (waiting on @junghans)
FindOmega_h.cmake, line 4 at r1 (raw file):
# # \file cmake/FindOmega_h.cmake # \copyright 2018, Los Alamos National Security, LLC.
No t really a big deal, but I think if you use 2016-2018
instead of only 2018
, quinoa::src/script/update_copyright.sh will catch it next time.
TPLs.cmake, line 164 at r1 (raw file):
find_package(Omega_h) if(OMEGA_H_FOUND) set(HAS_OMEGA_H true) # will become compiler define in Main/QuinoaConfig.h
Sounds good! Let's keep it optional with a compiler define.
Comments from Reviewable
Reviewed 1 of 1 files at r2. Review status: all files reviewed, 2 unresolved discussions (waiting on @junghans)
Comments from Reviewable
Review status: all files reviewed, 2 unresolved discussions (waiting on @jbakosi)
FindOmega_h.cmake, line 4 at r1 (raw file):
No t really a big deal, but I think if you use `2016-2018` instead of only `2018`, [quinoa::src/script/update_copyright.sh](https://github.com/quinoacomputing/quinoa/blob/master/script/update_copyright.sh) will catch it next time.
Done.
TPLs.cmake, line 164 at r1 (raw file):
Sounds good! Let's keep it optional with a compiler define.
Done.
Comments from Reviewable
This change is