search

quinoacomputing / quinoa

Adaptive computational fluid dynamics
https://quinoacomputing.github.io
Other
101 stars 21 forks source link

Fix cmake detection of CBLAS #590

Closed adityakpandare closed 10 months ago

adityakpandare commented 1 year ago

Quinoa's cmake configuration fails to pick up cblas libraries (either cblas.h or gsl_cblas.h), and fails at the linking step. As a provisional fix, the cblas library and header can be included as follows:

  1. replace the <cblas.h> in src/Base/Vector.hpp with the full path of the cblas header file,
  2. add the cblas library to the linker line using the -DCMAKE_EXE_LINKER_FLAGS option.

This needs to be fixed, so that cmake detects the cblas header and library path, and throws an error during configuration (rather than at linking) if cblas is not found.

adityakpandare commented 10 months ago

https://github.com/quinoacomputing/quinoa-tpl/commit/71b69be7aaa45d4fa7a0e1f4d481eb2bf1114cda addresses this from the TPL-side.

adityakpandare commented 10 months ago

See https://github.com/quinoacomputing/quinoa/commit/8bf1359cbbca6d039161670a1b85333ce9ebe5ab and https://github.com/quinoacomputing/cmake-modules/commit/09494f3425a93277960b87b6d6fd4f8248901f27.