search

quinoacomputing / quinoa

Adaptive computational fluid dynamics
https://quinoacomputing.github.io
Other
101 stars 22 forks source link

p-adaptation finalized for multi-material #626

Closed adityakpandare closed 2 months ago

adityakpandare commented 2 months ago

In addition to @WeizhaoLi2018's p-adaptive multimaterial changes, this change-set also removes the old least-squares (LS) reconstruction functions that used only the face-neighbors. Why:

  1. It was tested that this choice of neighbor-stencil can be unstable. The better choice is to use node-neighbors, which is expensive due to the large neighborhood, but very stable.
  2. It wasn't being used.
  3. The upkeep of this LS scheme was turning out to be more than initially thought.

Removing the face-neighbor LS means that compflow and transport cannot work with scheme="p0p1" anymore.

This change is Reviewable