Closed mabijkerk closed 5 months ago
There are still some GQL functions that need documentation and now have "TO-DO". What was your intention with these functions
@mabijkerk I'm not experienced enough to determine wether they should be included in the documentation and/or how to explain the working of these functions (all fever queries for example). Would be great if you could take a look at these.
First of all, it is really awesome that this knowledge is now available for everyone, absolutely love the fact I can fall back on this documentation for those sparse moments in which I have to write queries. The lay-out (explanation + example) makes it really practical as well. Thank you for that!
Hereby some very small comments:
Again, good busy!
Thanks for the review @Charlottevm! I have implemented your feedback for the most part. Could you check if I have missed anything? The following functions in the file miss proper documentation and are marked as TO-DO:
FEVER_PRODUCTION_CURVE_FOR_COUPLE FEVER_DEMAND_CURVE_FOR_PEOPLE
@mabijkerk Could you perhaps take a look at these?
This PR adds documentation for GQL. It partly retrieves the information from this outdated page and partly directly from the ETEngine functions. Some documentation is new.
There are four critical points for review:
There are still some GQL functions that need documentation and now have "TO-DO". What was your intention with these functions @kaskranenburgQ?