quintel / etengine

Calculation engine for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
15 stars 7 forks source link

Discrete inputs handled as continious inputs #1321

Closed robcalon closed 1 year ago

robcalon commented 1 year ago

There are several discrete values in the scenario inputs that have a min and max value, which probably should have a permitted_values list similar to the 'settings_weather_curve_set' input. It is now possible to assign these boolean like inputs with strange values like 0.5 that in some cases are scenario breaking.

        'heat_storage_enabled',
        'merit_order_subtype_of_energy_power_nuclear_uranium_oxide',
        'settings_enable_merit_order',
        'settings_enable_storage_optimisation_energy_flexibility_hv_opac_electricity',
        'settings_enable_storage_optimisation_energy_flexibility_pumped_storage_electricity',
        'settings_enable_storage_optimisation_energy_flexibility_mv_batteries_electricity',
        'settings_enable_storage_optimisation_energy_flexibility_flow_batteries_electricity',
        'settings_enable_storage_optimisation_transport_car_flexibility_p2p_electricity',

Being able to recognize these boolean-like inputs directly would make it easier to interpolate the scenario and get some additional feedback from the engine when passing an invalid number.

github-actions[bot] commented 1 year ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.