quintel / etengine

Calculation engine for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
14 stars 7 forks source link

Costs data export should be restructured #1325

Closed mabijkerk closed 5 months ago

mabijkerk commented 1 year ago

PR https://github.com/quintel/etengine/pull/1323 fixed erroneous results in the costs data export (which is generated with this serializer). The fixes in the PR ensured that the results from the data export aligned with the results shown in the costs charts in the ETM frontend.

The PR included a minor improvement in the structure of the export. The structure is still rather unclear, so further improvements should be made:

Notifying @DorinevanderVlies in case I've missed additional potential improvements.

mabijkerk commented 1 year ago

For reference, see this mapping of the II3050 European governance scenario: Kosten - mapping van export naar grafieken (II3050 EUR).xlsx

github-actions[bot] commented 1 year ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

github-actions[bot] commented 1 year ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

mabijkerk commented 5 months ago

@KoenvanB can this issue be closed?

KoenvanB commented 5 months ago

Yes, it can be closed. The costs download has undergone a complete overhaul during the pilot for FIT project, so most improvement suggestions have become moot.