quintel / etengine

Calculation engine for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
14 stars 7 forks source link

Review input of bio resources #1365

Open mabijkerk opened 9 months ago

mabijkerk commented 9 months ago

The "Biomass demand and potential" chart includes the query chp_heat_and_electricity_from_wet_biomass, which makes use of the attribute input_of_bio_resources.

This attribute is defined in capacity_production.rb:

      # Public: The sum of all bio resources input.
      #
      # Returns a numeric value in MJ.
      def input_of_bio_resources
        fetch(:input_of_bio_resources) do
          input_of_dry_biomass +
            input_of_wet_biomass +
            input_of_oily_biomass +
            input_of_biogenic_waste +
            input_of_torrefied_biomass_pellets +
            input_of_wood_pellets +
            input_of_waste_mix +
            input_of_bio_kerosene +
            input_of_bio_lng +
            input_of_bio_oil +
            input_of_biodiesel +
            input_of_bio_ethanol +
            input_of_biogas +
            input_of_greengas +
            input_of_network_gas +
            input_of_compressed_network_gas +
            input_of_gas_power_fuelmix
        end
      end

However, network_gas consists of natural gas and green gas, compressed_network_gas is the same and gas_power_fuelmix consists of bio oil, crude oil and network gas. These last three products are not purely bio resources, so I do wonder why they are listed here. @noracato do you happen to know something about this?

noracato commented 9 months ago

It looks like the full method was added in the biomass project in 2019 (see #1064) and never updated afterwards. This method was added by @redekok, maybe she remembers more?

redekok commented 9 months ago

I think Michiel was the mastermind behind this function actually. But it had something to do with recursively checking the amount of bio resources needed for compressed network gas for example. I can't provide you the details by heart right now but we could dive into it when time permits!